Skip to content

Comments

PodExecutorV2#898

Merged
thomas-waite merged 22 commits intodevelopfrom
pod-executor-v2
Jun 16, 2022
Merged

PodExecutorV2#898
thomas-waite merged 22 commits intodevelopfrom
pod-executor-v2

Conversation

@thomas-waite
Copy link
Contributor

@thomas-waite thomas-waite commented Jun 12, 2022

Feature

PodExecutorV2

Fixes a bug in the PodExecutor.sol whereby the executeBatch() method was not correctly exposed. Also updates an event to emit the proposalId rather than a custom hash of the data being executed.

Adds much more extensive testing, with most state variables that are touched being tested.

Benefit of a PodExecutor contract vs making EXECUTOR an open role

The main benefit using a PodExecutor contract vs making the EXECUTOR role an open role and publicly available is that the PodExecutor is pauseable. It will allow the Guardian to pause the contract and prevent execution if an issue is found with a queued transaction.

TODO

  • Add test for proposalId emitted in event
  • Deploy new contract and validate
  • e2e tests for execute() and executeBatch()
  • Deprecate old EXECUTOR
  • TC proposal to grant EXECUTOR role to this contract
  • Verification that a proposal can be batch executed through this

PR Checklist - Feature (Proposal)

  • All Tests Passing
  • Proposal Added to ProposalsConfig
  • Fork Block Correct
  • Remove Any .only's on Tests
  • Update Documentation If Needed
  • Update Roles Config
  • Proposal Submitted

@thomas-waite thomas-waite added the bug Something isn't working label Jun 12, 2022
@thomas-waite thomas-waite self-assigned this Jun 12, 2022
@thomas-waite thomas-waite changed the title [WIP] PodExecutorV2 PodExecutorV2 Jun 13, 2022
@thomas-waite thomas-waite marked this pull request as ready for review June 13, 2022 12:04
@thomas-waite thomas-waite requested a review from a team as a code owner June 13, 2022 12:04
Joeysantoro
Joeysantoro previously approved these changes Jun 14, 2022
xklob
xklob previously approved these changes Jun 14, 2022
xklob
xklob previously approved these changes Jun 14, 2022
eswak
eswak previously approved these changes Jun 16, 2022
Copy link
Contributor

@eswak eswak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomas-waite thomas-waite merged commit 1c412f7 into develop Jun 16, 2022
@thomas-waite thomas-waite deleted the pod-executor-v2 branch June 16, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants