Merged
Conversation
76fc0dc to
1f1314e
Compare
13578fa to
cc26765
Compare
1976c92 to
9dc4c1f
Compare
51ff926 to
57df6c9
Compare
6d7aec9 to
7859419
Compare
thomas-waite
commented
Jun 14, 2022
thomas-waite
commented
Jun 14, 2022
Joeysantoro
previously approved these changes
Jun 14, 2022
xklob
reviewed
Jun 14, 2022
xklob
previously approved these changes
Jun 14, 2022
1041b94 to
a5475a8
Compare
xklob
previously approved these changes
Jun 14, 2022
eswak
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
PodExecutorV2
Fixes a bug in the
PodExecutor.solwhereby theexecuteBatch()method was not correctly exposed. Also updates an event to emit theproposalIdrather than a custom hash of the data being executed.Adds much more extensive testing, with most state variables that are touched being tested.
Benefit of a PodExecutor contract vs making EXECUTOR an open role
The main benefit using a PodExecutor contract vs making the EXECUTOR role an open role and publicly available is that the PodExecutor is pauseable. It will allow the Guardian to pause the contract and prevent execution if an issue is found with a queued transaction.
TODO
execute()andexecuteBatch()PR Checklist - Feature (Proposal)