Merged
Conversation
added 4 commits
June 5, 2022 10:43
xklob
previously approved these changes
Jun 5, 2022
thomas-waite
reviewed
Jun 6, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks good to me, would clear up some of the comments
xklob
previously approved these changes
Jun 6, 2022
| { | ||
| target: 'pcvGuardianNew', | ||
| values: '0', | ||
| method: 'setSafeAddresses(address[])', |
Contributor
There was a problem hiding this comment.
Metacomment - there is a singular version of this function that is easier to call
thomas-waite
reviewed
Jun 6, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks good to me! Want to deploy and verify the contracts, then add to this PR before merging?
| expect(ethGained).to.be.bignumber.at.most(ethers.constants.WeiPerEther.mul(6)); | ||
|
|
||
| // Put in 10k DAI, got out ~5 WETH | ||
| // Implies price of $2000 per WETH |
Contributor
Author
|
Contracts deployed and verified Calldata: Execute Calldata: |
thomas-waite
previously approved these changes
Jun 7, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Looks good to me, minor comments
| console.log('WETH gained: ', ethGained); | ||
|
|
||
| // Accelerate time and check ended | ||
| await time.increase(LBP_FREQUENCY); |
Contributor
There was a problem hiding this comment.
I also fast forwarded time, performed a second swap and validated that the amountOut increased - to check that the weights were decreasing as expected. No strong feelings, it's a bit paranoid
| }, | ||
| ethToDaiLBPPool: { | ||
| artifactName: 'IWeightedPool', | ||
| address: '0x34809aEDF93066b49F638562c42A9751eDb36DF5', |
Contributor
There was a problem hiding this comment.
Would recommend verifying this LBPPool contract and inspecting the variables. Neat trick to verify these LBP pools is to pull the source code of an already verified contract and then use the standard-json input verification method:
curl -s [https://api.etherscan.io/api\?module\=contract\&action\=getsourcecode\&address\=0x32F0DC9E2D890BAC95106a65eB82db70Bc58BaDB\&apikey\=AETHERSCANPIKEY](https://api.etherscan.io/api/?module\=contract\&action\=getsourcecode\&address\=0x32F0DC9E2D890BAC95106a65eB82db70Bc58BaDB\&apikey\=AETHERSCANPIKEY) | jq -r '.result[0].SourceCode' | sed 's/{{/{/' | sed 's/}}/}/' > sol.json
thomas-waite
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type: Feature
PR Description: This proposal accomplishes two ETH PCV related actions.
PR Checklist - Feature (Proposal)