Merged
Conversation
Contributor
|
Update of https://github.com/fei-protocol/fei-protocol-core/blob/develop/protocol-configuration/tribalchief.ts not needed ? I'm surprised |
Contributor
Author
Simplest solution is to just tell the TribalChief that new block rewards are 0. Alternative approach would have been to set the APs of all pools to 0 |
Joeysantoro
reviewed
Jun 1, 2022
thomas-waite
commented
Jun 2, 2022
thomas-waite
force-pushed
the
end-tribe-incentives
branch
from
cac88e9 to
bd07d8d
Compare
thomas-waite
force-pushed
the
end-tribe-incentives
branch
from
32b646e to
333c21e
Compare
Joeysantoro
reviewed
Jun 2, 2022
thomas-waite
commented
Jun 3, 2022
thomas-waite
force-pushed
the
end-tribe-incentives
branch
from
df9feff to
86dceff
Compare
thomas-waite
force-pushed
the
end-tribe-incentives
branch
from
5af053c to
20309b3
Compare
Joeysantoro
reviewed
Jun 3, 2022
Joeysantoro
reviewed
Jun 3, 2022
Joeysantoro
reviewed
Jun 3, 2022
Joeysantoro
approved these changes
Jun 3, 2022
|
|
||
| const delegatorReportedSpeed = await contracts.rariRewardsDistributorDelegator.compSupplySpeeds(d3Ctoken); | ||
| expect(delegatorReportedSpeed).to.equal(0); | ||
| }; |
Contributor
There was a problem hiding this comment.
you should verify here that all AutoRewardsDistributors are set to 0 alloc points as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discontinue TRIBE incentives
Enact the passed TribalCouncil proposal to discontinue Tribe incentives.
Specifically this:
Items for later