Conversation
Joeysantoro
commented
Mar 3, 2021
| uint256 root = radicand.sqrt(); | ||
| if (root > reserveTarget) { | ||
| return root - reserveTarget; | ||
| return (root - reserveTarget).mul(1000).div(997); |
Contributor
Author
There was a problem hiding this comment.
need to add in the 30bps to the amount because Uniswap will take them away during the trade
Joeysantoro
commented
Mar 3, 2021
| int256 signedReservesFei = reserveFei.toInt256(); | ||
| uint256 adjustedReserveFei = | ||
| signedReservesFei.add(amountFei).toUint256(); | ||
| int256 amountFeiWithFee = amountFei.mul(997).div(1000); |
Contributor
Author
There was a problem hiding this comment.
need to take away the 30bps that uniswap will when calculating the slippage
sebastiandelgado
approved these changes
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uniswap fee wasn't included in reweights and direct incentive calculations so we needed to add it