Conversation
81aa629 to
437362e
Compare
577bc23 to
eed187a
Compare
eed187a to
434f695
Compare
| const setup: SetupUpgradeFunc = async (addresses, oldContracts, contracts, logging) => { | ||
| console.log(`No actions to complete in setup for fip${fipNumber}`); | ||
| const stakeAmount = ethers.constants.WeiPerEther.mul(40_000); | ||
| const curve3Metapool = '0x06cb22615BA53E60D67Bf6C341a0fD5E718E1655'; |
There was a problem hiding this comment.
This is a fixture that sets up a staker to have some TRIBE rewards to claim.
It is later relied on in an e2e test to ensure that the ending of incentives does not stop people who were staking LP tokens from claiming rewards. It will be removed along with the test once the proposal executes.
6cb21d2 to
df49537
Compare
df49537 to
1f77029
Compare
proposals/dao/fip_104b.ts
Outdated
There was a problem hiding this comment.
that's ~3% away from the current pool state, if DPI price changes too much before your proposal executes, the e2e setup step will fail, I think you should be more laxist on your sanity checks. For DPI for instance you checked balance of at least 1,500 where the spot pool content is 2,000, this gives more margin. Not a big deal but I wanted to share this with you, we had to update e2es because of this before
There was a problem hiding this comment.
That makes sense. I'll be less strict in the future on sanity checks
Summary
Withdraws liquidity from the DPI LBP once the auction has finished. End state is the DAI is on the
compoundPCVDaiDepositand theDPIis on the TribalCouncil Safe. The DPI is intended to be sold via 1inch once on the TC safe.To
exitPool()on the LBP, thePCV_CONTROLLERrole is required - so this is a DAO proposal, which will likely be consolidated with other actions.