Skip to content

Prepare LBP withdraw#821

Merged
thomas-waite merged 20 commits intodevelopfrom
prep-lbp-withdraw
Jun 7, 2022
Merged

Prepare LBP withdraw#821
thomas-waite merged 20 commits intodevelopfrom
prep-lbp-withdraw

Conversation

@thomas-waite
Copy link
Contributor

@thomas-waite thomas-waite commented May 18, 2022

Summary

Withdraws liquidity from the DPI LBP once the auction has finished. End state is the DAI is on the compoundPCVDaiDeposit and the DPI is on the TribalCouncil Safe. The DPI is intended to be sold via 1inch once on the TC safe.

To exitPool() on the LBP, the PCV_CONTROLLER role is required - so this is a DAO proposal, which will likely be consolidated with other actions.

@thomas-waite thomas-waite requested a review from a team as a code owner May 18, 2022 18:02
@thomas-waite thomas-waite self-assigned this May 18, 2022
@thomas-waite thomas-waite changed the base branch from develop to consolidate-to-one-vote May 18, 2022 20:41
Base automatically changed from consolidate-to-one-vote to develop May 19, 2022 20:36
@thomas-waite thomas-waite force-pushed the prep-lbp-withdraw branch 2 times, most recently from 577bc23 to eed187a Compare May 23, 2022 15:44
const setup: SetupUpgradeFunc = async (addresses, oldContracts, contracts, logging) => {
console.log(`No actions to complete in setup for fip${fipNumber}`);
const stakeAmount = ethers.constants.WeiPerEther.mul(40_000);
const curve3Metapool = '0x06cb22615BA53E60D67Bf6C341a0fD5E718E1655';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fixture that sets up a staker to have some TRIBE rewards to claim.

It is later relied on in an e2e test to ensure that the ending of incentives does not stop people who were staking LP tokens from claiming rewards. It will be removed along with the test once the proposal executes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ~3% away from the current pool state, if DPI price changes too much before your proposal executes, the e2e setup step will fail, I think you should be more laxist on your sanity checks. For DPI for instance you checked balance of at least 1,500 where the spot pool content is 2,000, this gives more margin. Not a big deal but I wanted to share this with you, we had to update e2es because of this before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I'll be less strict in the future on sanity checks

eswak
eswak previously approved these changes Jun 7, 2022
@thomas-waite thomas-waite merged commit 2386902 into develop Jun 7, 2022
@thomas-waite thomas-waite deleted the prep-lbp-withdraw branch June 7, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments