Merged
Conversation
thomas-waite
force-pushed
the
consolidate-to-one-vote
branch
from
3518007 to
629e63f
Compare
thomas-waite
changed the title
thomas-waite
commented
May 18, 2022
thomas-waite
force-pushed
the
consolidate-to-one-vote
branch
from
6aa2a20 to
481031e
Compare
thomas-waite
force-pushed
the
consolidate-to-one-vote
branch
from
481031e to
9621995
Compare
eswak
reviewed
May 18, 2022
eswak
reviewed
May 18, 2022
thomas-waite
force-pushed
the
consolidate-to-one-vote
branch
from
6dfb790 to
2388607
Compare
thomas-waite
force-pushed
the
consolidate-to-one-vote
branch
from
0d0e1c0 to
4ff1773
Compare
Joeysantoro
reviewed
May 18, 2022
Comment on lines
7
to
13
| { | ||
| target: 'core', | ||
| values: '0', | ||
| method: 'grantRole(bytes32,address)', | ||
| arguments: ['0x0866eae1216ed05a11636a648003f3f62921eb97ccb05acc30636f62958a8bd6', '{daiFixedPricePSMFeiSkimmer}'], | ||
| description: 'Grant the new DAI PSM Skimmer the PCV_CONTROLLER_ROLE' | ||
| }, |
Contributor
There was a problem hiding this comment.
just flagging that this is unscalable and we should try to revitalize the sink efforts when things settle down
Contributor
Author
There was a problem hiding this comment.
As discussed, have removed this in favour of setting an appropriate PCV deposit to be a safe address, pulling funds there and then burning
Joeysantoro
reviewed
May 18, 2022
Comment on lines
16
to
29
| { | ||
| target: 'dpi', | ||
| values: '0', | ||
| method: 'transfer(address,uint256)', | ||
| arguments: ['{dpiToDaiLBPSwapper}', '37888449801955370645659'], | ||
| description: 'Transfer DPI from DAO timelock to the LBP swapper' | ||
| }, | ||
| { | ||
| target: 'compoundDaiPCVDeposit', | ||
| values: '0', | ||
| method: 'withdraw(address,uint256)', | ||
| arguments: ['{dpiToDaiLBPSwapper}', '187947000000000000000000'], | ||
| description: 'Withdraw DAI from the CompoundPCVDeposit and transfer to the LBP pool' | ||
| }, |
Contributor
There was a problem hiding this comment.
what happens if DPI price changes? make sure to overfund DAI, or whitelist the swapper as a safe address
Contributor
Author
There was a problem hiding this comment.
Good point. Currently over funded by ~$9k DAI as price of DPI has dipped and I have whitelisted as a safe address so we can fine-tune as necessary
xklob
reviewed
May 18, 2022
Joeysantoro
previously approved these changes
May 18, 2022
eswak
previously approved these changes
May 19, 2022
further overfund
Joeysantoro
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates various PCV reinforcement strands into one proposal for execution, and performs a couple of needed technical maintenance tasks. DAO vote is necessary as several of the funds are on the DAO timelock (Cream and DPI) and we need to give out the PCV_CONTROLLER role.
uniswapPCVDepositanddpiToDaiLBPSwapperas safe addresses