Conversation
xklob
commented
May 24, 2022
Contributor
There was a problem hiding this comment.
Will have a think about attack vectors and edge cases, only have small comments so far. Added suggestion for the role
Main thing as you say is the tests for multiple transactions. I would probably break those out into an actual e2e test file rather than just do in the validate() function
eswak
reviewed
May 25, 2022
Joeysantoro
reviewed
May 25, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
My feedback was addressed + have reviewed the subsequently pushed commits
Joeysantoro
reviewed
May 25, 2022
Joeysantoro
reviewed
May 25, 2022
Contributor
Author
|
Deployed to |
Contributor
Author
|
Verified on etherscan: https://etherscan.io/address/0xfe7547f583aae1212e72e063aac25057c06c4797#code |
…tocol-core into feat/clear-bad-debt
Joeysantoro
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a contract,
FuseFixer.sol, that gives capabilities of paying back bad debt specifically for the exploiter.The bad debt can be repaid over multiple transactions, or all at once.
Is not opinionated about how the contract gets its assets.
Todo: need to add tests for the "multiple transactions" path.
Todo: need to think about how this could be griefed, and preventions we might want to implement.
(note that we have a slippage parameter of sorts in two ways: first, by not sending too many assets to this contract; second, by using the individual-repay method and providing a maximum amount)