Skip to content

Balancer Gauge Staker#799

Merged
eswak merged 14 commits intodevelopfrom
fix/bal-gauge-staker
May 23, 2022
Merged

Balancer Gauge Staker#799
eswak merged 14 commits intodevelopfrom
fix/bal-gauge-staker

Conversation

@eswak
Copy link
Contributor

@eswak eswak commented May 12, 2022

New contract to stake in Balancer Gauges.

The old contract can still be used for BAL vote-locking and gauge voting, but a 2nd (new contract, this one) is needed to stake in gauges. The old contract can claim the gauge rewards, but can't call the Balancer Minter contract, so there is a large part of the BAL rewards it can't claim.

This new contract can interact with the Balancer Minter and is deployed under a proxy. Balancer team said they'll try to delegate the veBAL boost from our veBAL locking contract to this proxy, so that gauge staking still farms BAL rewards with a boost.

Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review. Keen to understand the original issue with claiming and then will review further

@eswak eswak marked this pull request as ready for review May 17, 2022 13:48
@eswak eswak requested a review from a team as a code owner May 17, 2022 13:48
@eswak eswak linked an issue May 18, 2022 that may be closed by this pull request
xklob
xklob previously approved these changes May 19, 2022
@eswak
Copy link
Contributor Author

eswak commented May 20, 2022

Calldata to be used by the Tribal Council Safe, sent on the Tribal Council Timelock 0xe0C7DE94395B629860Cbb3c42995F300F56e6d7a :

Queue: 0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001c000000000000000000000000000000000000000000000000000000000000002c00000000000000000000000000000000000000000000000000000000000000000df8b3bac0344eccc903839fb260123ba49c2621cf1e499cfebd6e607c8e2f26d0000000000000000000000000000000000000000000000000000000000054600000000000000000000000000000000000000000000000000000000000000000700000000000000000000000002435948f84d7465fb71de45aba6098fc6ec29930000000000000000000000008d5ed43dca8c2f7dfb20cf7b53cc7e593635d7b900000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000002435948f84d7465fb71de45aba6098fc6ec299300000000000000000000000066977ce30049cd0e443216bf26377966c3a109e2000000000000000000000000ff6f59333cfd8f4ebc14ad0a0e181a83e655d257000000000000000000000000ff6f59333cfd8f4ebc14ad0a0e181a83e655d25700000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000700000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000001c00000000000000000000000000000000000000000000000000000000000000240000000000000000000000000000000000000000000000000000000000000034000000000000000000000000000000000000000000000000000000000000003c0000000000000000000000000000000000000000000000000000000000000044000000000000000000000000000000000000000000000000000000000000000241ec4990900000000000000000000000066977ce30049cd0e443216bf26377966c3a109e20000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000442f2ff15d3bee38c33241595abfefa470fd75bfa1cc9cb01eff02cf6732fd2baea4ea4241000000000000000000000000e0c7de94395b629860cbb3c42995f300f56e6d7a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044dcfbd26300000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e8450000000000000000000000004f9463405f5bc7b4c1304222c1df76efbd81a4070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c41fc8084a000000000000000000000000c5bb8f0253776bec6ff450c2b40f092f7e7f5b5700000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e84500000000000000000000000000000000000000000000358be2bbca6b6efb46cd00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044c382400200000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e84500000000000000000000000000000000000000000000358be2bbca6b6efb46cd000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044562f80fa000000000000000000000000673f7dfa863b611de657759aede629b260f4e6820000000000000000000000008465e7cfa63aa6682531c7a34141966318ac5178000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024dea0289200000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000000000000000000000000000000000000

Execute: 0xe38335e500000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000002a00000000000000000000000000000000000000000000000000000000000000000df8b3bac0344eccc903839fb260123ba49c2621cf1e499cfebd6e607c8e2f26d000000000000000000000000000000000000000000000000000000000000000700000000000000000000000002435948f84d7465fb71de45aba6098fc6ec29930000000000000000000000008d5ed43dca8c2f7dfb20cf7b53cc7e593635d7b900000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000002435948f84d7465fb71de45aba6098fc6ec299300000000000000000000000066977ce30049cd0e443216bf26377966c3a109e2000000000000000000000000ff6f59333cfd8f4ebc14ad0a0e181a83e655d257000000000000000000000000ff6f59333cfd8f4ebc14ad0a0e181a83e655d25700000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000700000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000014000000000000000000000000000000000000000000000000000000000000001c00000000000000000000000000000000000000000000000000000000000000240000000000000000000000000000000000000000000000000000000000000034000000000000000000000000000000000000000000000000000000000000003c0000000000000000000000000000000000000000000000000000000000000044000000000000000000000000000000000000000000000000000000000000000241ec4990900000000000000000000000066977ce30049cd0e443216bf26377966c3a109e20000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000442f2ff15d3bee38c33241595abfefa470fd75bfa1cc9cb01eff02cf6732fd2baea4ea4241000000000000000000000000e0c7de94395b629860cbb3c42995f300f56e6d7a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044dcfbd26300000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e8450000000000000000000000004f9463405f5bc7b4c1304222c1df76efbd81a4070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c41fc8084a000000000000000000000000c5bb8f0253776bec6ff450c2b40f092f7e7f5b5700000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e84500000000000000000000000000000000000000000000358be2bbca6b6efb46cd00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044c382400200000000000000000000000090291319f1d4ea3ad4db0dd8fe9e12baf749e84500000000000000000000000000000000000000000000358be2bbca6b6efb46cd000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044562f80fa000000000000000000000000673f7dfa863b611de657759aede629b260f4e6820000000000000000000000008465e7cfa63aa6682531c7a34141966318ac5178000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024dea0289200000000000000000000000066977ce30049cd0e443216bf26377966c3a109e200000000000000000000000000000000000000000000000000000000

@thomas-waite thomas-waite self-requested a review May 20, 2022 15:26
Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eswak eswak merged commit fa21b7f into develop May 23, 2022
@eswak eswak deleted the fix/bal-gauge-staker branch May 23, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Balancer Gauge Staker (fixed, calling BalancerMinter)

5 participants

Comments