Withdraw 30M LP tokens from Convex and 10M Fei from D3 Pool#791
Withdraw 30M LP tokens from Convex and 10M Fei from D3 Pool#791thomas-waite merged 20 commits intodevelopfrom
Conversation
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
5717848 to
38aaeef
Compare
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
38aaeef to
840ad08
Compare
thomas-waite
changed the title
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
521d169 to
792a50a
Compare
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
2aaff8f to
1f4721d
Compare
thomas-waite
changed the title
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
2 times, most recently
from
468143e to
0ef84f8
Compare
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
0ef84f8 to
dc64a3a
Compare
contracts/pcv/utils/FeiSkimmer.sol
Outdated
|
|
||
| /// @notice Set the target to skim from. Only Governor or Admin | ||
| /// @param newSource the new source to skim from | ||
| function setSource(address newSource) external onlyGovernorOrAdmin { |
There was a problem hiding this comment.
if you're going to use the onlyGovernorOrAdmin modifier, you have to set the admin of this contract in the constructor
There was a problem hiding this comment.
It's set by default in CoreRef, which this contract inherits from, to GOVERNOR. That's a bit redundant at the moment as the GOVERNOR can call this method anyway, but the contract admin could be changed in the future to something else.
Should stay as is imo
There was a problem hiding this comment.
Have thought about this some more. In the recent governance upgrade, we changed the admin of the feiSkimmer contracts to the PCV_MINOR_PARAM_ROLE. That role is intended to only manage minor PCV related parameters and should not have the scope to change the source in my opinion (as it would get in this change).
Going to change setSource to be onlyGovernor and then setContractAdmin internally to PCV_MINOR_PARAM_ROLE to avoid having to do later in a DAO vote.
Will then redeploy
There was a problem hiding this comment.
Cool, that makes sense!
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
2 times, most recently
from
882596f to
5008a39
Compare
thomas-waite
force-pushed
the
withdraw-from-d3pool
branch
from
5008a39 to
32acabd
Compare
4 participants
Summary
Withdraws 30M Fei from the Curve D3 pool.
Uses the PCVGuardian to first pull the LP tokens from the Convex PCVDeposit and send them to the Curve PCVDeposit. Then withdraws 10M Fei from the Curve PCVDeposit and sends it to the DAI PSM. Two further transactions will be made in the future to withdraw additional Fei. Makes use of the TribalCouncil to do this.
A Fei Skimmer is also deployed for the DAI PSM to enable Fei to be skimmed off the DAI PSM. A DAO vote is required to do this, as the
PCV_CONTROLLER_ROLEneeds granting.