Add sanity check tests to Gov upgrade#783
Merged
thomas-waite merged 10 commits intodevelopfrom May 10, 2022
Merged
Conversation
thomas-waite
force-pushed
the
gov-more-tests
branch
from
52700a6 to
3c289b8
Compare
eswak
reviewed
May 9, 2022
Contributor
eswak
left a comment
eswak
left a comment
There was a problem hiding this comment.
looks good, would it make sense to add more tests for "sad paths" ? for instance, revert if a random person tries to queue a transaction on the TC, or have a NopeDAO action cancel a timelocked action
eswak
previously approved these changes
May 9, 2022
xklob
reviewed
May 9, 2022
thomas-waite
force-pushed
the
gov-more-tests
branch
8 times, most recently
from
27b1895 to
9030c7d
Compare
thomas-waite
force-pushed
the
gov-more-tests
branch
from
9030c7d to
b76d182
Compare
xklob
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An e2e test to make sure the TribalCouncil timelock works, as well as a batch execute test