Remove var names from FIP script function calls#761
Merged
thomas-waite merged 3 commits intodevelopfrom Apr 29, 2022
Merged
Conversation
eswak
previously approved these changes
Apr 29, 2022
thomas-waite
force-pushed
the
remove-vars-from-fip82
branch
from
aff8191 to
26983ed
Compare
Joeysantoro
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Function call names
Removes the variable names from the FIP_82 var function calls. Do not believe this is necessarily needed as the compiler will generate the calldata from the function signature, but I think it's better practice and more in keeping with how other FIP scripts are run.
The FIP script also fails in debug mode with the var names in.
FIP description
Updates the FIP description for Tally and adds the names of those elected to the council member addresses being added