Controller upgrade path#734
Merged
thomas-waite merged 5 commits intofeat-governance-upgradefrom Apr 26, 2022
Merged
Conversation
thomas-waite
force-pushed
the
upgrade-path
branch
from
aa2dcd5 to
86c2cb1
Compare
Joeysantoro
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for allowing pods to upgrade their own controller versions.
In the Orca protocol, pods are able to upgrade their own controller. Currently we would not fully support this as the factory is based on a hard coded initial pod controller set at deploy time.
This PR updates the factory to instead get the relevant pod's controller at run time, by using the member token as the source of truth (this never changes). It means that we now support pods being able to upgrade to a newer pod version to take account of upgrade features.
We still do not support any new admin features, as the pod admins are set immutably to a
PodAdminGatewaycontract. This is okay for our purposes as we have all admin functionality we require already - add member, remove member, lock and unlock.