Merged
Conversation
thomas-waite
force-pushed
the
turbo-rollout
branch
from
99b8b19 to
a264094
Compare
thomas-waite
force-pushed
the
turbo-rollout
branch
from
b4bd5d8 to
e9e9731
Compare
Joeysantoro
reviewed
Apr 19, 2022
scripts/deploy/turboRolloutConfig.ts
Outdated
|
|
||
| export const pool18Config = { | ||
| supplyCap: ethers.utils.parseEther('2000000'), // 2M, units of Fei | ||
| // TODO: Complete with real once deployed |
Joeysantoro
previously approved these changes
Apr 19, 2022
Contributor
Joeysantoro
left a comment
Joeysantoro
left a comment
There was a problem hiding this comment.
LGTM, we'll also need to set the custom fee splits on the two collaterals on the TurboClerk.
I don't think thats a blocker to deploy this and begin testing
thomas-waite
force-pushed
the
turbo-rollout
branch
from
b4d9090 to
6df0572
Compare
Joeysantoro
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete Turbo rollout: