Merged
Conversation
thomas-waite
force-pushed
the
feat-nope-dao
branch
from
d32489c to
c8a0d02
Compare
Joeysantoro
reviewed
Mar 28, 2022
Joeysantoro
reviewed
Mar 28, 2022
Joeysantoro
reviewed
Mar 28, 2022
prevent NopeDAO from adjusting own params
thomas-waite
force-pushed
the
feat-nope-dao
branch
from
b000470 to
07ed0b7
Compare
thomas-waite
commented
Mar 30, 2022
thomas-waite
force-pushed
the
feat-nope-dao
branch
from
def7e0f to
e69dd0b
Compare
thomas-waite
commented
Mar 31, 2022
Joeysantoro
reviewed
Mar 31, 2022
| //////////// GOVERNOR ONLY FUNCTIONS ////////////// | ||
|
|
||
| /// @notice Override of a Governor Settings function, to restrict to Tribe GOVERNOR | ||
| function setVotingDelay(uint256 newVotingDelay) |
Contributor
There was a problem hiding this comment.
delay can be hardcoded to zero
Contributor
Author
There was a problem hiding this comment.
Have hardcoded to 0 in the GovernorSettings constructor.
Still having the setter in order to override the underlying method and make it only calleable by the Tribe DAO - want to maintain usage of GovernorSettings more broadly so that the TribeDAO can change the other parameters
thomas-waite
force-pushed
the
feat-nope-dao
branch
from
4fb9e55 to
f6f3e38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the NopeDAO - a DAO governed by Tribe who's only functionality is to veto pods.
Based on OZ Governor - this is compatible with Tally.