Skip to content

wrapper#584

Merged
Joeysantoro merged 7 commits intodevelopfrom
feat/wrapperImprovements
Mar 24, 2022
Merged

wrapper#584
Joeysantoro merged 7 commits intodevelopfrom
feat/wrapperImprovements

Conversation

@Joeysantoro
Copy link
Contributor

Make things immutable and streamlined

@Joeysantoro Joeysantoro requested a review from a team as a code owner March 11, 2022 03:54
eswak
eswak previously approved these changes Mar 11, 2022
Copy link
Contributor

@eswak eswak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

how does it run, DEPOSIT=0xabcd... npx hardhat run scripts/deploy/wrapper.ts ?

xklob
xklob previously approved these changes Mar 12, 2022
@Joeysantoro
Copy link
Contributor Author

Joeysantoro commented Mar 18, 2022

cool

how does it run, DEPOSIT=0xabcd... npx hardhat run scripts/deploy/wrapper.ts ?

DEPOSIT=0x525eA5983A2e02abA8aA0BE7D15Cd73150812379 DEPLOY_FILE=wrapper npx hardhat run --network mainnet scripts/deploy/migrations.ts

I was thinking about adding an npm script but hopefully we can move away from these wrappers in general

@Joeysantoro Joeysantoro dismissed stale reviews from xklob and eswak via 4b9ce50 March 24, 2022 22:05
Joey Santoro added 2 commits March 24, 2022 15:31
Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Joeysantoro Joeysantoro merged commit af20f22 into develop Mar 24, 2022
@Joeysantoro Joeysantoro deleted the feat/wrapperImprovements branch March 24, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments