Skip to content

FIP-85: Kill RGT rewards on RGT/ETH SushiSwap pair#579

Merged
Joeysantoro merged 22 commits intodevelopfrom
feat/kill-rgt-sushi-rewards
Mar 25, 2022
Merged

FIP-85: Kill RGT rewards on RGT/ETH SushiSwap pair#579
Joeysantoro merged 22 commits intodevelopfrom
feat/kill-rgt-sushi-rewards

Conversation

@davidlucid
Copy link
Contributor

No description provided.

@davidlucid davidlucid requested a review from a team as a code owner March 7, 2022 23:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these numbers ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

568717819057309757517546 * 80 / 100 is the original quantity distributed over the original period of 6500 * 365 * 3: https://etherscan.io/address/0x2197ecc5b1ea917adcf02dcc4343b0e9b8a8c99c#code
Since we are changing the period to 6500 * (365 + 30), we must multiply the quantity by (365 + 30) / (365 * 3): https://etherscan.io/address/0x4650a83520be4f1e4cee726fdd169d37cea80525#code

values: '0',
method: 'setDisabled(bool)',
arguments: [false],
description: 'Re-enable the RariGovernanceTokenUniswapDistributor'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to disable it to call the upgrade function, then we re-enable it so users who have unclaimed RGT can still claim (even though future distributions are stopped).

@eswak
Copy link
Contributor

eswak commented Mar 8, 2022

You also need to test the test/integration/proposals_config file to add the execution of your proposal to the e2e flow

Joeysantoro
Joeysantoro previously approved these changes Mar 21, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a contract artifact with the abi called by the dao script here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just add an interface to external folder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably shouldn't be in here

@Joeysantoro Joeysantoro merged commit 7d424d9 into develop Mar 25, 2022
@Joeysantoro Joeysantoro deleted the feat/kill-rgt-sushi-rewards branch March 25, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments