Merged
Conversation
- Add warning if setup() function is not empty - Add optional env variable READ_CR_ORACLE that reads CR oracle before & after, and prints the difference
thomas-waite
previously approved these changes
Mar 2, 2022
Contributor
thomas-waite
left a comment
thomas-waite
left a comment
There was a problem hiding this comment.
Really like this + the colours are great
xklob
previously requested changes
Mar 2, 2022
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
See comment about moving the func to a different file. Also not a huge fan of directly embedding color/terminal format strings in console logs, but should be fine as long as its not something we start doing everywhere.
scripts/utils/checkProposal.ts
Outdated
| process.exit(1); | ||
| }); | ||
|
|
||
| function formatNumber(x) { |
Contributor
There was a problem hiding this comment.
Can you move this out into a utils file somewhere? Would prefer to keep our checkproposal logic/file clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of warning:
Example of CR oracle reading:
