Apply consistent formatting to Solidity#554
Merged
thomas-waite merged 6 commits intodevelopfrom Feb 26, 2022
Merged
Conversation
4793230 to
69944ec
Compare
ElliotFriedman
approved these changes
Feb 26, 2022
Contributor
ElliotFriedman
left a comment
There was a problem hiding this comment.
Ty for the alpha leak! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies consistent formatting and linting to Solidity code. Introduced as we have differences appearing on our PRs and different formatting styles across our Solidity codebase.
Specifically, it introduces
prettierto apply consistent formatting to our Solidity code. Runnpm run prettier:solto auto-format all code. To find linting errors run:npm run lint:sol. The config used to decide the formatting rules is incontracts/.prettierrc.The Solidity linting has been added into CI. All Solidity file changes are formatting changes only - the result of applying the below config.
The config I have used is is mostly the default, feel free to propose changes: