Skip to content

FIP-83: La Tribu (hiring devs from DAO)#553

Merged
eswak merged 16 commits intodevelopfrom
feat/la-tribu
Mar 7, 2022
Merged

FIP-83: La Tribu (hiring devs from DAO)#553
eswak merged 16 commits intodevelopfrom
feat/la-tribu

Conversation

@eswak
Copy link
Contributor

@eswak eswak commented Feb 25, 2022

@ElliotFriedman
Copy link
Contributor

LGTM!

@eswak eswak self-assigned this Feb 27, 2022
@thomas-waite thomas-waite self-requested a review February 27, 2022 13:09
Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, but a question about process. Why aren't we hiring the engineers first and then setting up timelocks for the individual engineers later once they are hired?

At the moment, when these contracts are deployed then vesting will start immediately I believe. But those engineers likely won't have been hired (or at least if one of them has been hired, it's very unlikely that the other will also have been hired at the same time).

I feel that the engineers should have their own compensation timelocks where they are the beneficiary, granted by the DAO

thomas-waite
thomas-waite previously approved these changes Feb 28, 2022
@ElliotFriedman ElliotFriedman requested a review from a team as a code owner March 1, 2022 01:39
@ElliotFriedman
Copy link
Contributor

@ditchfieldcaleb This PR did not require any approval to merge according to the new git bot that was just set up
Screen Shot 2022-02-28 at 9 19 21 PM
. I think that this type of PR should require reviews before merging.

thomas-waite
thomas-waite previously approved these changes Mar 1, 2022
@xklob
Copy link
Contributor

xklob commented Mar 2, 2022

@ditchfieldcaleb This PR did not require any approval to merge according to the new git bot that was just set up Screen Shot 2022-02-28 at 9 19 21 PM . I think that this type of PR should require reviews before merging.

After merging develop into this branch it should require reviews/approvals

@xklob xklob changed the base branch from develop to PCVDepositAggregator March 2, 2022 05:11
@xklob xklob changed the base branch from PCVDepositAggregator to develop March 2, 2022 05:11
@xklob xklob dismissed thomas-waite’s stale review March 2, 2022 05:11

The base branch was changed.

@xklob
Copy link
Contributor

xklob commented Mar 2, 2022

@ditchfieldcaleb This PR did not require any approval to merge according to the new git bot that was just set up Screen Shot 2022-02-28 at 9 19 21 PM . I think that this type of PR should require reviews before merging.

After merging develop into this branch it should require reviews/approvals

Fixed, just had to change base branch to something else and then back again for it to see it, since this PR was created before CODEOWNERS existed.

xklob
xklob previously approved these changes Mar 2, 2022
Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eswak eswak merged commit f4a06f6 into develop Mar 7, 2022
@eswak eswak deleted the feat/la-tribu branch March 7, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments