Skip to content

Fix Timelock Admin#55

Merged
Joeysantoro merged 1 commit intoPOZ-Fixesfrom
POZ-Fix-Timelock-Admin
Feb 7, 2021
Merged

Fix Timelock Admin#55
Joeysantoro merged 1 commit intoPOZ-Fixesfrom
POZ-Fix-Timelock-Admin

Conversation

@Joeysantoro
Copy link
Contributor

@Joeysantoro Joeysantoro commented Feb 7, 2021

This is not in scope for OZ but it is a major issue and small code change so if you have time to review that would be amazing.

Fixes an issue where the Fei team admin is unintentionally set as the Timelock admin. This would effectively give Fei control over all of the PCV (subject to a timelock) which is unintended behavior.

Made some changes to allow for the atomic linking of the timelock and governor alpha at t=0.

Also changed voting delay from 2 days to 1 day

@Joeysantoro Joeysantoro added OZ Fix New A PR dedicated to fix an OpenZeppelin issue Extra Scope This code wasn't explicitly in an audit but please review labels Feb 7, 2021
@Joeysantoro Joeysantoro merged commit 06fa7bf into POZ-Fixes Feb 7, 2021
Joeysantoro added a commit that referenced this pull request Jul 19, 2021
@xklob xklob deleted the POZ-Fix-Timelock-Admin branch September 19, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra Scope This code wasn't explicitly in an audit but please review OZ Fix New A PR dedicated to fix an OpenZeppelin issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments