Skip to content

Style Cleanup#54

Merged
Joeysantoro merged 1 commit intoPOZ-Fixesfrom
POZ-Style-Cleanup
Feb 7, 2021
Merged

Style Cleanup#54
Joeysantoro merged 1 commit intoPOZ-Fixesfrom
POZ-Style-Cleanup

Conversation

@Joeysantoro
Copy link
Contributor

Resolves OZ audit issues N06, N29

Decided not to update any style discrepancies in dao to keep changes to forked code to a minimum

Summary:

  • ran VSCode format on all contract files except mock and dao (this made uint->uint256 happen)
  • Enforced internal functions begin with _ convention
  • Ran solhint and added ignore on relevant areas
  • made _feiTribeExchangeRate internal

@Joeysantoro Joeysantoro changed the base branch from master to POZ-Fixes February 7, 2021 18:41
@Joeysantoro Joeysantoro added the OZ Fix New A PR dedicated to fix an OpenZeppelin issue label Feb 7, 2021
@Joeysantoro Joeysantoro merged commit c1eecbe into POZ-Fixes Feb 7, 2021
Joeysantoro added a commit that referenced this pull request Jul 19, 2021
@xklob xklob deleted the POZ-Style-Cleanup branch September 19, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OZ Fix New A PR dedicated to fix an OpenZeppelin issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments