PCVSentinel#506

Merged

xklob merged 65 commits intodevelopfrom

feat/PCVSentinel

Apr 1, 2022

Contributor

xklob commented Jan 26, 2022

No description provided.

xklob and others added 7 commits

January 25, 2022 21:52


          initial framework

0f57958


          Merge branch 'develop' into feat/PCVSentinel

aca6103


          use interfaces properly and re-org somewhat

0d5d115


          Merge branch 'feat/PCVSentinel' of github.com:fei-protocol/fei-protoc…

f0e6f69

…ol-core into feat/PCVSentinel


          comments and updates

d480168


          Merge branch 'develop' into feat/PCVSentinel

1b2264d


          add interface and pause method

aca2bff

Joeysantoro reviewed

View reviewed changes

contracts/pcv/sentinel/IGuard.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/IPCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/IPCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

xklob added 10 commits

January 26, 2022 16:10


          commit inprogress work


          simplify

d571bda

fix

7037ff1


          use try catch

e953b92


          protecMany comment

b8325cf


          make no-op guard

12f0692


          add missing function to interface

58cab60


          add missing public view funcs

e6ee337


          empty tests and example guards

93b11fb


          tests

377b482

xklob changed the title ~~[WIP] PCV Sentinel~~ PCVSentinel

xklob requested review from ElliotFriedman and Joeysantoro

January 27, 2022 08:47


          comment cleanup

7783d42

eswak reviewed

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

eswak reviewed

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

eswak reviewed

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

eswak reviewed

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

eswak reviewed

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

eswak reviewed

View reviewed changes

test/unit/pcv/sentinel/PCVSentinel.test.ts Outdated Show resolved Hide resolved

Joeysantoro previously requested changes

View reviewed changes

contracts/pcv/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

Joeysantoro reviewed

View reviewed changes

contracts/pcv/sentinel/guards/examples/BalanceGuard.sol Outdated Show resolved Hide resolved

xklob added 16 commits

March 22, 2022 09:35


          initial proposal

e389c29


          add to proposals config

26b2fd4


          fix sentinel

fix

e4a4ae3


          fix array error

47f4b00


          fix tests

eead03c


          fix test again

c72fe9d


          remove unused imports

b08fe21


          fix no-op guard

c0d92de


          TribeRoles and fix bug

ed9e005


          update roles

b7aa34a


          fix roles again

cc50599


          add balance check

ee2f781


          add in proposal data

3471d68


          fix bug

296a9cb


          add entry into mainnet addresses

5d3773b

Joeysantoro reviewed

View reviewed changes

contracts/sentinel/PCVSentinel.sol Outdated Show resolved Hide resolved

Joeysantoro previously approved these changes

View reviewed changes


          fix typo

e0b5c36

xklob dismissed Joeysantoro’s stale review via

e0b5c36

March 22, 2022 20:06


          update with deployed address, remove old proposals from proposals config

b9924f1

xklob dismissed ElliotFriedman’s stale review

March 23, 2022 03:52

stale

xklob added 4 commits

March 22, 2022 21:27


          permissions update

c341b40


          update proposalid

fe9ed61


          Merge branch 'develop' into feat/PCVSentinel

a3027df


          fix merge conflicts

36ddfb1

xklob changed the base branch from develop to PCVDepositAggregator

April 1, 2022 03:56

xklob changed the base branch from PCVDepositAggregator to develop

April 1, 2022 03:56

xklob merged commit f94c6bd into develop

xklob deleted the feat/PCVSentinel branch

April 1, 2022 04:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet