Conversation
xklob
previously requested changes
Dec 31, 2021
| const contract = contracts[j]; | ||
| const category = addresses[contract].category; | ||
| if (category === 'External' || category === 'Deprecated') { | ||
| if (category === 'External') { |
Contributor
There was a problem hiding this comment.
You should make an enum for these categories in the types file and import it here instead of using string literals
Contributor
There was a problem hiding this comment.
(and also probably use said enum everywhere else if you can do that without manually editing 500+ lines of code)
Contributor
Author
There was a problem hiding this comment.
it already was an enum. Used it here
| } | ||
| }); | ||
|
|
||
| it('all dependencies bidirectional', async function () { |
Contributor
There was a problem hiding this comment.
I know this wasn't an edit on this pr but the string "Check dependencies all dependencies bidirectional" doesn't tell me what it's checking, maybe something like "Check dependencies are listed bidirectionally" would?
Contributor
Author
There was a problem hiding this comment.
changed this and others
…rotocol-core into feat/deprecated-check
xklob
previously approved these changes
Dec 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds deprecated contracts signoff category for proposals_config.
Adds an integration test to require that these contracts are in fact deprecated and not contained anywhere in dependencies map