Conversation
Contributor
|
I changed it to TRIBAL_CHIEF_ADMIN_ROLE for now and we can have OA do it. |
| await contracts.stakingTokenWrapperBribeD3pool.harvest(); | ||
| const briberBalanceAfter = await contracts.tribe.balanceOf(contracts.votiumBriberD3pool.address); | ||
| const bribeAmount = briberBalanceAfter.sub(briberBalanceBefore); | ||
| expect(bribeAmount).to.be.at.least('1'); |
Contributor
There was a problem hiding this comment.
There should be a higher quality test here that does a bit more than just checking the bribe amount is at least 1. With current allocation points, it should be thousands of tribe if you have 250 AP
ElliotFriedman
previously requested changes
Dec 29, 2021
xklob
previously requested changes
Dec 30, 2021
ElliotFriedman
previously approved these changes
Dec 30, 2021
Contributor
ElliotFriedman
left a comment
ElliotFriedman
left a comment
There was a problem hiding this comment.
I would add an IT that tests the pausing. Other than that, LGTM!
added 2 commits
December 30, 2021 17:39
xklob
approved these changes
Dec 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new VotiumBriber contract that can collect a rewards stream from the Tribal Chief and bribe with it.
I only did e2e tests because unit tests would just be testing my mock behaviors.
Open question : who do we empower to make the bribe calls ? Could be the OA multisig (not timelock), one of our addresses, a new multisig, a new multisig with timelock... Let's discuss on the forum & on discord.