Conversation
This function does not have the afterTime modifier, and is governor only. This allows to start auctions from DAO proposals, without relying on external contracts to manage them.
xklob
previously requested changes
Nov 11, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Overall it looks fine, but for a PR with potential impact of this magnitude, I'd like to specifically see some integration tests (even if they're throwaway-after-this-is-executed!) that test swaps after the PR executes.
proposals/dao/fip_41.ts
Outdated
| target: 'lusd', | ||
| values: '0', | ||
| method: 'transfer(address,uint256)', | ||
| arguments: ['{feiLusdLBPSwapper}', '1089000000000000000000000'], |
Contributor
There was a problem hiding this comment.
we'll need to make sure we submit the dao-execute transaction via flashbots protect, or someone could grief this swap
xklob
reviewed
Nov 11, 2021
| }, | ||
| ethers.constants.WeiPerEther.mul(200_000), | ||
| ethers.constants.WeiPerEther // huge deadline | ||
| ); |
Contributor
There was a problem hiding this comment.
would be good to check balances in between each swap. doesn't have to be exact, just asset that the balance of the swapped-in asset increases in the bool and the balance of the swapped-out asset decreases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auction 100M FEI for LUSD using a Balancer LBP, over 2 weeks.
Note: Fei Labs will spend 1,100,000 FEI to get LUSD, and send those to the swapper.
The DAO proposal includes a refund of this FEI.
Snapshot: https://snapshot.org/#/fei.eth/proposal/0x0e5f05a0c51938b904d9932849251ae920403b75301f90567da9d1ed857965c3
0x5052BfbB7972E702179f3Eeed43B9213819b681a), to be confirmed with Liquity/Rari team.