Conversation
|
Overall looks really great, you can fix these nits then send to Tokemak team for review. Also feel free to begin DAO scripts |
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Contracts look great overall, just a couple of questions there. Roles all look fine and love the comments.
For the tests I left a lot of comments; most of them are code-style things (we've updated the way we do tests quite a bit in the past few months).
| const TOKEMAK_REWARDS_ADDRESS = '0x79dD22579112d8a5F7347c5ED7E609e60da713C5'; | ||
| const TOKEMAK_WETH_POOL_ADDRESS = '0xD3D13a578a53685B4ac36A1Bab31912D2B2A2F36'; | ||
| const TOKEMAK_TOKE_POOL_ADDRESS = '0xa760e26aA76747020171fCF8BdA108dFdE8Eb930'; |
There was a problem hiding this comment.
nit: These should probably be added to mainnetAddresses.json right?
There was a problem hiding this comment.
I just needed them here, but I can add them. What artifactName do I use ?
|
After fixing merge conflicts and pulling in develop should be good to 🚢 |
eswak
force-pushed
the
feat/tokemak-deposit
branch
from
fe36f46 to
1895f01
Compare
|
fixed the e2e tests, didn't know about the and up to date vs 🚢 ? |
3 participants
This pull request implements smart contracts for depositing ETH & ERC20s on Tokemak.