Merged
Conversation
Joeysantoro
reviewed
Nov 4, 2021
Joeysantoro
reviewed
Nov 4, 2021
Joeysantoro
previously requested changes
Nov 4, 2021
Contributor
Joeysantoro
left a comment
Joeysantoro
left a comment
There was a problem hiding this comment.
Very good overall, one main comment and a bunch of nits
Contributor
Author
|
todo: make modifiers onlyGovernorOrAdminOrGuardian too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCV Guardian interface, implementation, and unit tests.
The PCV Guardian functions will (mostly) be only callable by the guardian-or-governor.
The Governor is the only role that will be able to add "safe" addresses that the guardian can choose to withdraw to.
The Guardian can call into the PCV Guardian (which itself will be a pcv controller and a guardian) and withdraw from any pcv deposit into any safe address.