Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to fix OpenZeppelin audit report issue H02.
The idea is to add introspection into whether an oracle has a stale value via new
IOracleinterface methodisOutdated(). Callers of the public read functions which rely on the oracle can check isOutdated and perform an update call if their flow depends on the accuracy of the info. We flag these methods that rely on the oracle in the dev section of the natspec.We also add an
updateOracle()call to the reweight function.All non-view user flows that rely on the peg should update the oracle at the beginning. The view functions except
isAtMaxPrice()which is deleted in another PR should all call out the dependency in the natspec