Conversation
xklob
suggested changes
Nov 1, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Swallowing all possible errors Isn't great. Can we change this to only swallow the error of "transaction reverted" and have any other errors throw?
I'm the one that originally commented this out because it was swallowing errors and caused us to miss a bug or two in proposal code awhile back.
xklob
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check proposal needs to pass through when proposal has already been voted on and executed.
There is a more elegant way to do this using the proposal state but these were already here just commented out