Skip to content

Add contract dependencies e2e test#276

Merged
Joeysantoro merged 6 commits intodevelopfrom
feat/contract-dependencies
Nov 1, 2021
Merged

Add contract dependencies e2e test#276
Joeysantoro merged 6 commits intodevelopfrom
feat/contract-dependencies

Conversation

@Joeysantoro
Copy link
Contributor

@Joeysantoro Joeysantoro commented Oct 30, 2021

Adds @addresses/dependencies.ts which documents the following:

  • FIPs affecting a given contract
  • contracts affecting each other
  • external dependencies

these are used in @test/integration/dependencies.ts which tests:

  • all contracts changed in a fip are in the dependencies log, and signed off
  • all dependencies logged are bidirectional

"signed off" means that a developer intentionally adds a flag to the dependencies file saying they checked the contract and any effects of the FIP.

Adds more types and changes several files from json to ts including:

  • proposals descriptions
  • proposals_config

A future PR will get the contract dependencies up to state of truth

@Joeysantoro Joeysantoro changed the title [WIP] refactor contract dependencies Add contract dependencies e2e test Oct 30, 2021
@Joeysantoro Joeysantoro marked this pull request as ready for review October 30, 2021 18:08
@Joeysantoro Joeysantoro merged commit 4d50316 into develop Nov 1, 2021
@Joeysantoro Joeysantoro deleted the feat/contract-dependencies branch November 1, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments