Conversation
xklob
suggested changes
Oct 20, 2021
| chai.use(CBN(ethers.BigNumber)); | ||
|
|
||
| // Constants | ||
| const TIMED_MINTER_FREQUENCY = '604800'; // weekly |
Contributor
Author
There was a problem hiding this comment.
Its frequency just do one round of mental gymnastics
xklob
previously approved these changes
Oct 20, 2021
| } | ||
|
|
||
| /// @notice triggers a minting of FEI by owner | ||
| function mint() public override onlyOwner { |
Contributor
There was a problem hiding this comment.
Who will the owner of this contract be? I would assume it's either the guardian or the OA multisig?
|
|
||
| /// @title OwnedTimedMinter | ||
| /// @notice A FeiTimedMinter that mints only when called by an owner | ||
| contract OwnedTimedMinter is FeiTimedMinter, Ownable { |
Contributor
There was a problem hiding this comment.
The e2e tests are trying to pull in artifact OwnableTimedMinter, but the contract is named OwnedTimeMinter so the names need to be reconciled for e2e to pass.
xklob
approved these changes
Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tribe.fei.money/t/fip-xx-fei-minting-for-optimistic-approval/3565