Skip to content

Test Cleanup Pt 1#25

Merged
Joeysantoro merged 7 commits intoPOZ-Fixesfrom
POZ-Test-Cleanup
Feb 6, 2021
Merged

Test Cleanup Pt 1#25
Joeysantoro merged 7 commits intoPOZ-Fixesfrom
POZ-Test-Cleanup

Conversation

@Joeysantoro
Copy link
Contributor

@Joeysantoro Joeysantoro commented Feb 3, 2021

Plan is to structure tests cleanly using the following patterns:

  • Test everything twice

  • test all relevant state and read functions after a state update

  • Try every param combo/condition change

  • Invalid conditions first

Adding a helpers class to standardize imports and some add basic utilities

This PR fixes:

  • bondingcurve
  • core
  • dao
  • genesis
  • oracle

@Joeysantoro Joeysantoro added the Extra Scope This code wasn't explicitly in an audit but please review label Feb 6, 2021
@Joeysantoro Joeysantoro changed the base branch from POZ-Combined to POZ-Fixes February 6, 2021 19:29
@Joeysantoro Joeysantoro changed the title Test Cleanup Test Cleanup Pt 1 Feb 6, 2021
@Joeysantoro Joeysantoro merged commit 5dfca37 into POZ-Fixes Feb 6, 2021
Joeysantoro added a commit that referenced this pull request Jul 9, 2021
Joeysantoro added a commit that referenced this pull request Jul 9, 2021
@xklob xklob deleted the POZ-Test-Cleanup branch September 19, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra Scope This code wasn't explicitly in an audit but please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments