Conversation
proposals/dao/fip_33.ts
Outdated
| 5. Set ORACLE_ADMIN role to admin for CR Oracle | ||
| 6. Set ORACLE_ADMIN role to admin for CR Oracle Wrapper | ||
| 7. Grant Oracle Admin role to Collateralization Oracle Guardian | ||
| 8. TODO ORACLE admin to OA ?? |
There was a problem hiding this comment.
Need to decide if we want OA to have admin powers on the oracles. It kind of makes sense because they may add new FEI deployments that need to be added
There was a problem hiding this comment.
@Joeysantoro what can oracle-admins affect, specifically, within the oracles?
There was a problem hiding this comment.
On CR Oracle admins can add/remove deposits and oracles
On CR Oracle Wrapper admins can set the deviation threshold and cache values
There was a problem hiding this comment.
Seems okay for now. We may want to discuss this more as a team since this is a lot of power.
| const CR_KEEPER_INCENTIVE = ethers.constants.WeiPerEther.mul(1000); // 1000 FEI | ||
|
|
||
| // CR oracle guardian | ||
| const CR_GUARDIAN_FREQUENCY = 12 * 60 * 60; // 12 hours |
There was a problem hiding this comment.
nit but shouldn't this be period instead of frequency?
|
See comments. Don't have the energy to do a fully thorough review of the actual DAO commands and a fully-in-depth review of the rest of it, but will do so tomorrow. |
|
Approved but what about the 3 remaining check marks @Joeysantoro ? |
Fixed 2 of them and added integration tests. Lets discuss OA one as a team |
2 participants
This deploy script includes the DAO actions for fully setting up the automated TRIBE buyback flow
TODO: