Conversation
This reverts commit 63b6514.
xklob
reviewed
Oct 14, 2021
ERC20 PCV deposit wrapper
…rotocol-core into feat/CR-Oracle-Deploy
…ctor Feat/integration tests refactor
…rotocol-core into feat/CR-Oracle-Deploy
CR oracle deploy
| returns (uint256 amountOut); | ||
|
|
||
| /// @notice send any surplus reserves to the PCV allocation | ||
| function allocateSurplus() external; |
Contributor
There was a problem hiding this comment.
Is this function incentivized, if so, how much?
Contributor
Author
There was a problem hiding this comment.
should be public and incentivized by a keeper contract
xklob
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.