Merged
Conversation
Joeysantoro
reviewed
Oct 13, 2021
| @@ -70,9 +71,19 @@ async function increaseTime(amount: number) { | |||
| } | |||
|
|
|||
| async function resetTime() { | |||
Contributor
There was a problem hiding this comment.
resetTime is a bit unexpected because it also resets state. Imo all usages should be changed to resetFork
Joeysantoro
reviewed
Oct 13, 2021
test/helpers.ts
Outdated
Contributor
There was a problem hiding this comment.
this will error if forking=false right?
Contributor
There was a problem hiding this comment.
What block does it use?
Contributor
Author
There was a problem hiding this comment.
Yes it might - fixed just now to make it more clear.
Contributor
Author
There was a problem hiding this comment.
Uses the most recent mainnet block that is viable (ie 3-4 blocks behind head)
Joeysantoro
reviewed
Oct 13, 2021
| url: `https://eth-mainnet.alchemyapi.io/v2/${mainnetAlchemyApiKey}`, | ||
| blockNumber: 13398685 | ||
| url: `https://eth-mainnet.alchemyapi.io/v2/${mainnetAlchemyApiKey}` | ||
| //blockNumber: <set> |
Contributor
There was a problem hiding this comment.
assuming this is still todo or what
Contributor
Author
There was a problem hiding this comment.
Not todo - just commented so that you can see how to specify a particular block number if you need it.
Joeysantoro
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.