Add Timelock and STW Deploy Scripts#242
Conversation
| @@ -0,0 +1,25 @@ | |||
| import { ethers } from 'hardhat'; | |||
| import { DeployUpgradeFunc } from '../../types/types'; | |||
There was a problem hiding this comment.
Use the @custom-types shorthand here
| } | ||
|
|
||
| if (!tribalChief) { | ||
| throw new Error('TribalChief environment variable contract address is not set'); |
There was a problem hiding this comment.
This is how the scripts I modeled this one from behaved.
There was a problem hiding this comment.
Right, but this comment says that tribalchief is an env. It's not - it's an imported var.
| @@ -0,0 +1,28 @@ | |||
| import { DeployUpgradeFunc } from '../../types/types'; | |||
There was a problem hiding this comment.
Use @custom-types shorthand here.
| throw new Error('ADMIN_ADDRESS environment variable contract address is not set'); | ||
| } | ||
|
|
||
| if (!tribalChiefOptimisticMultisig || !core) { |
There was a problem hiding this comment.
tribalChiefOptimisticMultisig isn't an env.
|
the one failing e2e test is fixed in pr #235 |
Joeysantoro
left a comment
Joeysantoro
left a comment
There was a problem hiding this comment.
Please add the scripts to package.json for ease of use
| export const deploy: DeployUpgradeFunc = async (deployAddress, addresses, logging = false) => { | ||
| const { tribalChief } = addresses; | ||
|
|
||
| const BENEFICIARY = process.env.BENEFICIARY; |
There was a problem hiding this comment.
Just in case lets make the env names specific to the contract so theres no collision. STAKED_TOKEN_BENEFICIARY or something
| const deploy: DeployUpgradeFunc = async (deployAddress, addresses, logging = false) => { | ||
| const { core } = addresses; | ||
|
|
||
| const adminAddress = process.env.ADMIN_ADDRESS; |
There was a problem hiding this comment.
Just in case lets make the env names specific to the contract so theres no collision. TIMELOCK_ADMIN_ADDRESS or something
…tocol/fei-protocol-core into feat/stw-timelock-deploy-scripts
3 participants
No description provided.