Conversation
Joeysantoro
added
Extra Scope
Joeysantoro
changed the title
Joeysantoro
added a commit
that referenced
this pull request
Jul 9, 2021
Make PCV Swapper an IPCVDeposit
Joeysantoro
pushed a commit
that referenced
this pull request
Sep 11, 2022
Merge public repo `develop` into private repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should resolve issue H01 and C02 in the OpenZeppelin audit report for Fei Protocol.
The goal is to set a max price on the bonding curve level rather than allowing uncapped price movement. We can then remove the early launch condition of the GenesisGroup and rely on a true max.
This has the added benefit of allowing Genesis to be uncapped in raise size with a worst outcome price of peg + buffer.