Conversation
xklob
previously approved these changes
Oct 12, 2021
…ript string interpolation in dao json
xklob
approved these changes
Oct 12, 2021
| ## Optional Step 4: Deploying and Updating Addresses | ||
| If your contract has an optional deployment step from above, you need to deploy your new contracts to mainnet before moving on to Step 5. | ||
|
|
||
| Run `DEPLOY_FILE=fip_x npm run deploy:fip` |
Contributor
There was a problem hiding this comment.
We should add a note here that says if you need to deploy to mainnet, you run DEPLOY_FILE=fip_x npm run deploy:fip --network mainnet and note that this step is not necessary when running E2E tests.
| Then run `npm run test:e2e` | ||
|
|
||
| ## Step 6: Propose on-chain | ||
| ## Step 5: Propose on-chain |
Contributor
There was a problem hiding this comment.
We need one more step before step 5 and that is simulating what happens with calldata you generated using npm run check-proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now FIP flows can write their deploy function only inside their proposals/dao script to stay focused on one file
README changes assume
runis already removed from the dao scripts