Removes web3, fixes some dependencies that openzeppelin test-helpers has on web3#235
Merged
Removes web3, fixes some dependencies that openzeppelin test-helpers has on web3#235
Conversation
Contributor
Author
|
Also moves old scripts & dao proposals into an "old" folder within their respective parent folders, so that typescript doesn't try to compile them. |
Contributor
|
e2e tests are failing. This is a weird quirk of the system where it needs to have something in the proposals_config. Try to find the dependency and fix it I think its in integration/setup/index.ts or something |
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
previously requested changes
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Joeysantoro
reviewed
Oct 12, 2021
Contributor
Author
|
@Joeysantoro can you fix the merge conflicts? Gotta head to bed. Fixed the other issues though. |
…ol-core into feat/remove-web3
Joeysantoro
approved these changes
Oct 12, 2021
Contributor
|
web3 🪓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.