Conversation
Joeysantoro
force-pushed
the
feat/FIP-30b
branch
from
3ffec61 to
3d7ce5f
Compare
xklob
reviewed
Oct 6, 2021
added 2 commits
October 5, 2021 23:20
xklob
suggested changes
Oct 6, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Should add an integration test that rolls back to the old timelock and then executes any random action.
added 2 commits
October 6, 2021 00:32
xklob
previously approved these changes
Oct 6, 2021
Joeysantoro
commented
Oct 6, 2021
proposals/description/fip_30b.txt
Outdated
Contributor
Author
There was a problem hiding this comment.
Can take this line out of summary. Also the title is automatically appended from the json so can remove the title line as well
xklob
approved these changes
Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade script for transitioning to new FeiDAO timelock. Does not revoke guardian from old timelock to preserve rollback capability.
TODO: