Collateralization guardian tests#221
Merged
Joeysantoro merged 6 commits intofeat/v2-phase1-fixesfrom Oct 6, 2021
Merged
Conversation
added 2 commits
October 4, 2021 22:53
xklob
suggested changes
Oct 5, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Looks good aside from a couple of things. I'd love to see a test that updates the cache 3-4 times in a row too though.
contracts/oracle/collateralization/CollateralizationOracleGuardian.sol
Outdated
Show resolved
Hide resolved
| let guardianAddress: string; | ||
| let governorAddress: string; | ||
| let oracleWrapper: CollateralizationOracleWrapper; | ||
| let core: any; |
Contributor
Author
There was a problem hiding this comment.
Theres some issues with this because the helpers file doesn't use types. If you can make a PR to convert that we can start typing Core going forward. While you're at it try to remove dependencies on web3
added 2 commits
October 5, 2021 13:58
Contributor
Author
3-4 is overkill, added one with 2x |
added 2 commits
October 5, 2021 23:59
xklob
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.