Added Deployment and Validation Scripts for RDA and ARD#220
Added Deployment and Validation Scripts for RDA and ARD#220ElliotFriedman merged 5 commits intomasterfrom
Conversation
Joeysantoro
left a comment
Joeysantoro
left a comment
There was a problem hiding this comment.
We should add _setContractAdminRole(keccak256("TRIBAL_CHIEF_ADMIN_ROLE"));
to the ARD too in the constructor
So far looks good other than missing a few checks
proposals/dao/feiRari.ts
Outdated
|
|
||
| /// check that the contracts were wired together properly | ||
| expect(await rewardsDistributorAdmin.hasRole(AUTO_REWARDS_DISTRIBUTOR_ROLE, autoRewardsDistributor.address)).to.be.true; | ||
| expect(await autoRewardsDistributor.rewardsDistributorAdmin()).to.be.equal(rewardsDistributorAdmin.address); |
There was a problem hiding this comment.
add a check that the OA timelock isContractAdmin() on the RDA
also check the rewardsDistributorContract on RDA is the Delegator
check getNewRewardSpeed() is correct for ARD, should be around 24 TRIBE/block
There was a problem hiding this comment.
tribe per block as calculated in the ARD is 24.193548387096774193 tribe per block
I double checked the math and added an extra test here to ensure this is the correct value and it is.
There was a problem hiding this comment.
add a check that the OA timelock
isContractAdmin()on the RDA
also check the rewardsDistributorContract on RDA is the Delegator
What about these two
There was a problem hiding this comment.
Added isContractAdmin check.
I need to add a check for the second one
There was a problem hiding this comment.
Last one can prob do without
There was a problem hiding this comment.
Added a check for it.
…dsDistributorDelegator
2 participants
No description provided.