v2 Phase 1 - Partition into 3 Parts#219
Merged
Joeysantoro merged 52 commits intomasterfrom Oct 8, 2021
Merged
Conversation
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
proposals/dao/v2Phase1-part3.ts
Outdated
Comment on lines
38
to
42
| 2. Grant Minter role to PCV Equity Minter | ||
| 3. Grant Minter role to Collateralization Oracle Keeper | ||
| 4. Grant Tribe Minter role to Tribe Reserve Stabilizer | ||
| 5. Grant Oracle Admin role to Collateralization Oracle Guardian | ||
| 6. Seed TRIBE to LBP Swapper |
Contributor
There was a problem hiding this comment.
I'm only seeing step 4 and 6 in the run script
Contributor
Author
There was a problem hiding this comment.
Yes, need to sync with you on the oracle-admin stuff.
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Joeysantoro
reviewed
Oct 5, 2021
Contributor
Author
|
Moved the role-grant of CollateralizationOracleKeeper to p3, since we're not deploying it to p3 anyway. |
ElliotFriedman
suggested changes
Oct 6, 2021
Joeysantoro
reviewed
Oct 6, 2021
Joeysantoro
reviewed
Oct 6, 2021
Joeysantoro
reviewed
Oct 6, 2021
Joeysantoro
reviewed
Oct 7, 2021
Joeysantoro
reviewed
Oct 7, 2021
Comment on lines
+417
to
+418
| 17. Revokes the pcv controller role from the old uniswap pcv controller. | ||
| 18. Revokes the minter role from the old uniswap pcv controller. |
Contributor
There was a problem hiding this comment.
We really need to communicate loudly that reweights are no longer used
Joeysantoro
reviewed
Oct 7, 2021
Joeysantoro
reviewed
Oct 7, 2021
Bug/fix calldata generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the v2 Phase 1 upgrade into 3 parts for both the deploy script and the dao script.
Adds proposal command stubs for the actual dao commands, as well as text descriptions (also mostly stubs).
Can't run anything right now since we haven't deployed any of it and FIP_30 hasn't completed yet.
Things to complete: