Conversation
added 14 commits
October 4, 2021 21:02
Joeysantoro
force-pushed
the
feat/v2-phase1-fixes
branch
from
a4351f1 to
5891f0e
Compare
Collateralization guardian tests
| /// @notice guardian set the cache values on collateralization oracle | ||
| /// @param protocolControlledValue new PCV value | ||
| /// @param userCirculatingFei new user FEI value | ||
| /// @dev make sure to pause the CR oracle wrapper or else the set value would be overwritten on next update |
Contributor
There was a problem hiding this comment.
Why not add logic in the collateralization oracle and this contract so that if you call setCache, it automatically pauses the collateralization oracle if it is not paused yet.
Contributor
Author
There was a problem hiding this comment.
This is a good suggestion, I originally didn't want to add complexity. Lets sync on it
xklob
approved these changes
Oct 13, 2021
ElliotFriedman
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.