Merged
Conversation
xklob
reviewed
Oct 3, 2021
contracts/dao/FeiDAO.sol
Outdated
| uint256 private _proposalThreshold = 2_500_000e18; | ||
|
|
||
| constructor(ERC20VotesComp tribe, ICompoundTimelock timelock) | ||
| address private _admin; |
xklob
suggested changes
Oct 4, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Looks good, but the address set in the FeiDAO smart contract for OLD_GOVERNOR doesn't match the address in the tests.
added 2 commits
October 3, 2021 17:34
xklob
approved these changes
Oct 4, 2021
added 2 commits
October 3, 2021 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates the DAO proposal steps for upgrading to the OZ governor. It also introduces a rollback mechanism which allows the guardian to revert back to a backup Governor Alpha in the event that the upgrade fails for one reason or another.
The rollback can be used at most once, and expires automatically on November 1 if not used beforehand.
TODO: