Merged
Conversation
xklob
approved these changes
Sep 23, 2021
proposals/dao/optimisticTimelock.ts
Outdated
| import { ethers } from "hardhat"; | ||
| import hre, { ethers } from "hardhat"; | ||
| import { expect } from "chai"; | ||
| const { time } = require('../../test/helpers'); |
Contributor
There was a problem hiding this comment.
should use import instead of require
| {from: tribalChiefOptimisticMultisigAddress} | ||
| ); | ||
|
|
||
| await time.increase('1000000'); |
Contributor
There was a problem hiding this comment.
are you sure this works? in my dive into the unit tests, I had to convert to a number before passing into time.increase
Contributor
Author
There was a problem hiding this comment.
Yeah the execution works
proposals/dao/optimisticTimelock.ts
Outdated
| }); | ||
|
|
||
| await tribalChiefOptimisticTimelock.queueTransaction( | ||
| '0x956F47F50A910163D8BF957Cf5846D573E7f87CA', |
Contributor
There was a problem hiding this comment.
nit, but for future should add a comment explaining what this address was (I looked it up on etherscan ofc)
Contributor
Author
There was a problem hiding this comment.
ah good call, I didn't use the feiAddress var because I wanted to use the exact calldata used by OA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new OA timelock deployment and makes a test for tx:
https://etherscan.io/tx/0x67c06a7f3d7849af89a894a63baecfbe19afb31904a04fc9ffb53b926bd85e02