Add Admin support on contract level for Fei Protocol#185
Merged
Joeysantoro merged 1 commit intomasterfrom Sep 23, 2021
Merged
Conversation
Contributor
|
the code looks ok, do we add tests for this trivial change ? |
Contributor
Author
|
No need, modifier already tested in CoreRef test
… On Sep 21, 2021, at 11:51 PM, Erwan Beauvois ***@***.***> wrote:
the code looks ok, do we add tests for this trivial change ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
xklob
approved these changes
Sep 23, 2021
Contributor
xklob
left a comment
xklob
left a comment
There was a problem hiding this comment.
Approved but see comments in Slack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced the concept of a "contract admin" with OA for TribalChief.
This PR adds admin support to contracts throughout the repo following the below general rule of thumb:
Notable exceptions:
NOTE: This PR will not affect any existing on-chain contracts. And future contracts will explicitly need to define an admin role and have this role granted to a multisig timelock through the DAO. By itself these contract changes are effectively a no-op