Collateralization Oracle Wrapper Refactor#162
Merged
Joeysantoro merged 7 commits intofeat/v2from Sep 12, 2021
Merged
Conversation
Joeysantoro
commented
Sep 12, 2021
Contributor
Author
There was a problem hiding this comment.
unrelated cleanup from merge conflict
|
|
||
| /// @title CollateralizationOracleKeeper | ||
| /// @notice a FEI timed minter which only rewards when updating the collateralization oracle | ||
| contract CollateralizationOracleKeeper is FeiTimedMinter { |
Contributor
Author
There was a problem hiding this comment.
Did not add a unit test for this class because it is such as simple override of the FeiTimedMinter.
| Decimal.D256 memory _thresholdLow = Decimal.from(10_000 - deviationThresholdBasisPoints).div(10_000); | ||
| Decimal.D256 memory _thresholdHigh = Decimal.from(10_000 + deviationThresholdBasisPoints).div(10_000); | ||
|
|
||
| obsolete = paused(); |
Contributor
Author
There was a problem hiding this comment.
removed the "paused" condition for exceeded deviation threshold. Feels unnatural to include that as a criteria
eswak
reviewed
Sep 12, 2021
Contributor
There was a problem hiding this comment.
the exception message should rather be "not outdated"
eswak
reviewed
Sep 12, 2021
| obsolete = obsolete || circFeiRatio.lessThan(_thresholdLow); | ||
| // CircFEI > threshold | ||
| obsolete = obsolete || circFeiRatio.greaterThan(_thresholdHigh); | ||
| function _isExceededDeviationThreshold(uint256 cached, uint256 current) internal view returns (bool) { |
Contributor
There was a problem hiding this comment.
I admit it's more elegant like this 😇
Joeysantoro
commented
Sep 12, 2021
| collateralizationOracleWrapper = _collateralizationOracleWrapper; | ||
| } | ||
|
|
||
| function _afterMint() internal override { |
Contributor
Author
There was a problem hiding this comment.
Updated to use afterMint hook
xklob
approved these changes
Sep 12, 2021
| obsolete = obsolete || circFeiRatio.lessThan(_thresholdLow); | ||
| // CircFEI > threshold | ||
| obsolete = obsolete || circFeiRatio.greaterThan(_thresholdHigh); | ||
| function _isExceededDeviationThreshold(uint256 cached, uint256 current) internal view returns (bool) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the CollateralizationOracleWrapper to use more transparent logic around deviation thresholds being exceeded. Also includes an interface and new update method that reverts unless the oracle is currently out of date.
The new update method is used in a keeper that incentivizes updates of the oracle.