Conversation
eswak
reviewed
Sep 7, 2021
eswak
reviewed
Sep 7, 2021
eswak
reviewed
Sep 7, 2021
eswak
reviewed
Sep 7, 2021
eswak
approved these changes
Sep 7, 2021
xklob
reviewed
Sep 10, 2021
| /// @author Fei Protocol | ||
| abstract contract RateLimitedMinter is RateLimited { | ||
|
|
||
| uint256 private constant MAX_FEI_LIMIT_PER_SECOND = 10_000e18; // 10000 FEI/s or ~860m FEI/day |
Contributor
There was a problem hiding this comment.
No reason to not add in methods here to have this changeable by governor.
Contributor
Author
There was a problem hiding this comment.
Will merge as is and add in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper abstract class which hard rate limits the speed with which FEI can be minted by a contract.
Uses a buffer that gets depleted as FEI is minted and replenishes over time up to the cap.
Does not use the Timed utility to allow extending contracts to use it for other use cases.
Extents the base _mintFei method of CoreRef so all minting operations are affected.
This class is intended to be used by the PCVEquityMinter once that is merged into the v2 branch