FIP-10b - Curve deposit#137
Merged
Joeysantoro merged 18 commits intofei-protocol:feat/v2from Sep 11, 2021
Merged
Conversation
Joeysantoro
reviewed
Aug 20, 2021
Contributor
Joeysantoro
left a comment
Joeysantoro
left a comment
There was a problem hiding this comment.
First pass only on the main solidity
Joeysantoro
reviewed
Aug 24, 2021
Joeysantoro
reviewed
Aug 24, 2021
Joeysantoro
reviewed
Aug 24, 2021
Joeysantoro
reviewed
Aug 25, 2021
- _lpToWithdraw capped at the total balance of the pcv deposit - Add Curve contracts in mainnetAddresses.json - migrate withdraw/deposit tests to e2e.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal adds a new
StableSwapOperatorV1contract to the protocol.It is a
PCVDepositused to manage liquidity in the Curve metapool [3crv, FEI]. No reweights, no FEI minting, and all state-changing functions are access-controlled. The idea is to reduce the attack surface in this first version, and keep it as simple as possible.The assumption is that 50M DAI have been raised through the bonding curve deployed in FIP-10a, and that the protocol owns 50M DAI deposited in Compound.
Short term actions :
StableSwapOperatorV1@Joeysantoro